fix: prevent service degradation on config reload failure#589
Open
qq173924384 wants to merge 1 commit intoContentSquare:masterfrom
Open
fix: prevent service degradation on config reload failure#589qq173924384 wants to merge 1 commit intoContentSquare:masterfrom
qq173924384 wants to merge 1 commit intoContentSquare:masterfrom
Conversation
When applyConfig() fails during hot reload, the old proxy was being destroyed before the new proxy was successfully initialized, causing partial service outage. Changes: - main.go: Use temporary variable to create and validate new proxy before replacing the global instance. On failure, cleanup new proxy and keep old proxy running. - proxy.go: Fix bug where maxIdleConns was incorrectly assigned MaxIdleConnsPerHost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConnectionPoolconfig is detected, the new proxy is fully initialized and validated before replacing the old one, preventing partial/broken state exposure.reloadSignalis closed and its goroutines are waited on viareloadWG, avoiding goroutine leaks.maxIdleConnsfield assignment: InnewReverseProxy,maxIdleConnswas incorrectly set tocfgCp.MaxIdleConnsPerHost; corrected tocfgCp.MaxIdleConns.Test plan
ConnectionPoolcorrectly creates and applies the new proxy before discarding the old onemaxIdleConnsis correctly set fromcfg.ConnectionPool.MaxIdleConns🤖 Generated with Claude Code